3.x: Fix ExecutorScheduler initializing Schedulers prematurely #7323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.x #7323 +/- ##
============================================
+ Coverage 99.53% 99.54% +0.01%
+ Complexity 6784 6783 -1
============================================
Files 751 751
Lines 47490 47491 +1
Branches 6378 6378
============================================
+ Hits 47269 47277 +8
+ Misses 102 96 -6
+ Partials 119 118 -1
Continue to review full report at Codecov.
|
vanniktech
approved these changes
Aug 25, 2021
This was referenced Aug 30, 2021
This was referenced Oct 18, 2021
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExecutorSchedulerhad a static field referencingSchedulersthus when usingRxJavaPlugins.createExecutorScheduler, it would still initialize the standard schedulers despite the intention of the create method. Using the static inner holder class idiom can prevent this, similar to howSchedulersdoes it.Related: #7306 (comment)